Issue 6210056: Fixes for Windows Release compiler complaints (overflow in const arith)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6210056: Fixes for Windows Release compiler complaints (overflow in const arith) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by robertphillips

Modified:
12 years, 1 month ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This takes care of the last Release mode Windows compiler complaints (ignoring the Fixed Point build). I "fixed" these by placing pragmas around them since they are functioning as intended. An alternate (but more invasive) way to do this would be to create an explicit -Infinity value (i.e., gIEEENegInfinity) and then using the positive & negative infinity values everywhere instead of deliberately causing overflows.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -0 lines)			Patch
M	samplecode/SampleFuzz.cpp	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/animator/SkDisplayNumber.cpp	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	tests/ScalarTest.cpp	View	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

committed as r3926

Expand All Messages | Collapse All Messages