Provide XHR as an alternative fetcher for ES5 sandboxed code

* Adds two possible fetchers to caja.js to load external scripts in ES5
* Enables some CSS tests in ES5 which were previously off
* Adds tests for provided fetchers

@4903

[ihab.awad, 2012-05-22 21:57:31]

lgtm++

http://codereview.appspot.com/6209089/diff/1/src/com/google/caja/plugin/caja.js
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/6209089/diff/1/src/com/google/caja/plugin/caja....
src/com/google/caja/plugin/caja.js:96: 'fetch': proxyFetchMaker(undefined)
We don't want to point by default at the proxy server shipped with the Caja
service?

http://codereview.appspot.com/6209089/diff/1/src/com/google/caja/plugin/guest...
File src/com/google/caja/plugin/guest-manager.js (right):

http://codereview.appspot.com/6209089/diff/1/src/com/google/caja/plugin/guest...
src/com/google/caja/plugin/guest-manager.js:143: setTimeout(function() {
There's a tab on the lhs of this line.

http://codereview.appspot.com/6209089/diff/1/tests/com/google/caja/plugin/es5...
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js (right):

http://codereview.appspot.com/6209089/diff/1/tests/com/google/caja/plugin/es5...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:48: if (inES5Mode)
Eek, please add curlies!

http://codereview.appspot.com/6209089/diff/1/tests/com/google/caja/plugin/es5...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:347: //
registerTest('testUrCajoledHtml', function testUrlCajoledHtml() { });
Spurious change

[Jasvir, 2012-06-05 03:16:30]

http://codereview.appspot.com/6209089/diff/1/src/com/google/caja/plugin/caja.js
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/6209089/diff/1/src/com/google/caja/plugin/caja....
src/com/google/caja/plugin/caja.js:96: 'fetch': proxyFetchMaker(undefined)
That is what not providing a value does.  Closure forces me to pass undefined
explicitly.

On 2012/05/22 21:57:31, ihab.awad wrote:
> We don't want to point by default at the proxy server shipped with the Caja
> service?

http://codereview.appspot.com/6209089/diff/1/src/com/google/caja/plugin/guest...
File src/com/google/caja/plugin/guest-manager.js (right):

http://codereview.appspot.com/6209089/diff/1/src/com/google/caja/plugin/guest...
src/com/google/caja/plugin/guest-manager.js:143: setTimeout(function() {
On 2012/05/22 21:57:31, ihab.awad wrote:
> There's a tab on the lhs of this line.

Done.

http://codereview.appspot.com/6209089/diff/1/tests/com/google/caja/plugin/es5...
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js (right):

http://codereview.appspot.com/6209089/diff/1/tests/com/google/caja/plugin/es5...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:48: if (inES5Mode)
On 2012/05/22 21:57:31, ihab.awad wrote:
> Eek, please add curlies!

Done.

http://codereview.appspot.com/6209089/diff/1/tests/com/google/caja/plugin/es5...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:347: //
registerTest('testUrCajoledHtml', function testUrlCajoledHtml() { });
Reverted.

On 2012/05/22 21:57:31, ihab.awad wrote:
> Spurious change