Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(320)

Issue 6206070: Node linking operator supports multiple links at once (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by lukas.toenne
Modified:
12 years ago
Reviewers:
brechtvl, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

A generalization of the modal node linking operator (for dragging from socket to socket). This operator still had some built-in assumptions about the connectivity of input/output sockets (1-to-n in all current node systems). For future node systems (e.g. flow-based particles) and for general customizable nodes the operator is now fully symmetric and supports all kinds of connectivity limits (1:1, 1:n, m:1, m:n). The operator data can also store a list of node links as opposed to a single link now, so that multiple links can be redirected at once. Holding the CTRL key when clicking a socket, all links from/to that socket are detached and can be moved to a different socket. This is useful for quickly appending a node without moving every individual link. Here's a short demo: http://www.pasteall.org/pic/31849

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -143 lines) Patch
source/blender/editors/space_node/node_draw.c View 2 chunks +5 lines, -2 lines 0 comments Download
source/blender/editors/space_node/node_edit.c View 5 chunks +188 lines, -138 lines 2 comments Download
source/blender/editors/space_node/node_intern.h View 1 chunk +5 lines, -3 lines 0 comments Download
source/blender/editors/space_node/node_ops.c View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
lukas.toenne
12 years ago (2012-05-15 07:52:05 UTC) #1
brechtvl
LGTM. http://codereview.appspot.com/6206070/diff/1/source/blender/editors/space_node/node_edit.c File source/blender/editors/space_node/node_edit.c (right): http://codereview.appspot.com/6206070/diff/1/source/blender/editors/space_node/node_edit.c#newcode2479 source/blender/editors/space_node/node_edit.c:2479: /* XXX links->data pointers are either held by ...
12 years ago (2012-05-15 12:34:49 UTC) #2
lukas.toenne
12 years ago (2012-05-15 12:38:38 UTC) #3
http://codereview.appspot.com/6206070/diff/1/source/blender/editors/space_nod...
File source/blender/editors/space_node/node_edit.c (right):

http://codereview.appspot.com/6206070/diff/1/source/blender/editors/space_nod...
source/blender/editors/space_node/node_edit.c:2479: /* XXX links->data pointers
are either held by the tree or freed already */
On 2012/05/15 12:34:49, brechtvl wrote:
> Does this "XXX" indicate that something needs to be fixed here? Otherwise I'd
> leave it out.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b