refreshToken should throw a TokenResponseException for 4xx

Credential.intercept should throw a TokenResponseException if refreshToken is false.

Fix for http://code.google.com/p/google-oauth-java-client/issues/detail?id=42 : Failures in Access token requests for OAuth 2.0 assertion profile shouldn't be caught.

[yanivi, 2012-05-11 17:49:08]

Please take a look at my comments from our internal e-mail thread.  We may need
to do something more subtle like throwing the exception on 4xx errors, but keep
existing logic for 5xx errors.  Let's delay this for the 1.10 release.

[rmistry, 2012-05-25 15:10:34]

Modified Credential.refreshToken to only handle 4xx.

[yanivi, 2012-06-05 21:05:21]

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java
(right):

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java:499:
public final boolean refreshToken() throws IOException {
I think we should throw the IOException on 4xx here too.  I understand this is a
breaking change, but quietly eating the IOException is probably not helping the
developer either.

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java:519:
*/
@since 1.10

[yanivi, 2012-06-05 21:05:49]

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java
(right):

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java:499:
public final boolean refreshToken() throws IOException {
On 2012/06/05 21:05:21, yanivi wrote:
> I think we should throw the IOException on 4xx here too.  I understand this is
a
> breaking change, but quietly eating the IOException is probably not helping
the
> developer either.

If so, then refreshToken(boolean) seems unnecessary

[rmistry, 2012-06-06 13:40:25]

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java
(right):

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java:499:
public final boolean refreshToken() throws IOException {
On 2012/06/05 21:05:21, yanivi wrote:
> I think we should throw the IOException on 4xx here too.  I understand this is
a
> breaking change, but quietly eating the IOException is probably not helping
the
> developer either.

Makes sense. Done.

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java:499:
public final boolean refreshToken() throws IOException {
On 2012/06/05 21:05:49, yanivi wrote:
> On 2012/06/05 21:05:21, yanivi wrote:
> > I think we should throw the IOException on 4xx here too.  I understand this
is
> a
> > breaking change, but quietly eating the IOException is probably not helping
> the
> > developer either.
> 
> If so, then refreshToken(boolean) seems unnecessary

Done.

http://codereview.appspot.com/6203063/diff/7002/google-oauth-client/src/main/...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java:519:
*/
On 2012/06/05 21:05:21, yanivi wrote:
> @since 1.10

Removed this method.

[yanivi, 2012-06-06 16:08:10]

LGTM