Issue 6202052: code review 6202052: freetype: make freetype clean wrt "go vet".

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6202052: code review 6202052: freetype: make freetype clean wrt "go vet". (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by nigeltao

Modified:
12 years, 6 months ago

Reviewers:

CC:
dsymonds, golang-dev

Visibility:
Public.

Description

freetype: make freetype clean wrt "go vet".

Patch Set 1 #

Patch Set 2 : diff -r c01529a12bec https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r c01529a12bec https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r c01529a12bec https://code.google.com/p/freetype-go #

Patch Set 5 : diff -r c01529a12bec https://code.google.com/p/freetype-go #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
M	example/gamma/main.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	example/raster/main.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	example/round/main.go	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	freetype/freetype.go	View	1 2	3 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

12 years, 6 months ago (2012-05-07 12:27:59 UTC) #1

nigeltao

12 years, 6 months ago (2012-05-07 12:52:12 UTC) #3

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=386b8c470049 ***

freetype: make freetype clean wrt "go vet".

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/6202052

Expand All Messages | Collapse All Messages