code review 6198043: freetype: fix overflow when converting from a uint16 gl...

freetype: fix overflow when converting from a uint16 glyph index to a
file offset.

[nigeltao, 2012-05-04 05:37:25]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bradfitz, 2012-05-04 05:41:10]

LGTM

On Fri, May 4, 2012 at 3:37 PM, <nigeltao@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
>
https://code.google.com/p/**freetype-go<https://code.google.com/p/freetype-go>
>
>
> Description:
> freetype: fix overflow when converting from a uint16 glyph index to a
> file offset.
>
> Please review this at
http://codereview.appspot.com/**6198043/<http://codereview.appspot.com/6198043/>
>
> Affected files:
>  M freetype/truetype/truetype.go
>
>
> Index: freetype/truetype/truetype.go
> ==============================**==============================**=======
> --- a/freetype/truetype/truetype.**go
> +++ b/freetype/truetype/truetype.**go
> @@ -568,11 +568,11 @@
>        // Find the relevant slice of f.glyf.
>        var g0, g1 uint32
>        if f.locaOffsetFormat == locaOffsetFormatShort {
> -               d := data(f.loca[2*i:])
> +               d := data(f.loca[2*int(i):])
>                g0 = 2 * uint32(d.u16())
>                g1 = 2 * uint32(d.u16())
>        } else {
> -               d := data(f.loca[4*i:])
> +               d := data(f.loca[4*int(i):])
>                g0 = d.u32()
>                g1 = d.u32()
>        }
>
>
>

[nigeltao, 2012-05-04 05:42:40]

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=6527496bd153 ***

freetype: fix overflow when converting from a uint16 glyph index to a
file offset.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/6198043