Issue 6197071: Add an endpoint to download the binary content of a patch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6197071: Add an endpoint to download the binary content of a patch (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Roger Tawa

Modified:
11 years, 11 months ago

Reviewers:
M-A

Visibility:
Public.

More Reviews

Description

Add an endpoint to download the binary content of a patch http://code.google.com/p/rietveld/source/detail?r=d9f35f2ee678d75e00606b971a04703e31d36edf&name=chromium

Patch Set 2 : Remove cache directive #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
M	codereview/urls.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	codereview/views.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	codereview/views_chromium.py	View	1	3 chunks	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Roger Tawa

Salut MA, Please take a look. I wonder if this change is really needed now ...

11 years, 11 months ago (2012-05-10 19:10:48 UTC) #1

M-A

lgtm http://codereview.appspot.com/6197071/diff/1/codereview/views_chromium.py File codereview/views_chromium.py (right): http://codereview.appspot.com/6197071/diff/1/codereview/views_chromium.py#newcode520 codereview/views_chromium.py:520: response['Cache-Control'] = 'no-cache, no-store' Not sure about the ...

11 years, 11 months ago (2012-05-10 19:19:57 UTC) #2

Remove cache directive

Expand All Messages | Collapse All Messages