trans-mem: functions making indirect calls are not transformed

[daveb, 2012-05-08 22:41:02]

 gcc/trans-mem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/trans-mem.c b/gcc/trans-mem.c
index 2badf25..24073fa 100644
--- a/gcc/trans-mem.c
+++ b/gcc/trans-mem.c
@@ -4721,7 +4721,7 @@ ipa_tm_transform_clone (struct cgraph_node *node)
   /* If this function makes no calls and has no irrevocable blocks,
      then there's nothing to do.  */
   /* ??? Remove non-aborting top-level transactions.  */
-  if (!node->callees && !d->irrevocable_blocks_clone)
+  if (!node->callees && !node->indirect_calls && !d->irrevocable_blocks_clone)
     return;
 
   current_function_decl = d->clone->decl;
-- 
1.7.9.5


--
This patch is available for review at http://codereview.appspot.com/6194061

[patrick.marlier_gmail.com, 2012-05-15 21:33:54]

Follow-up of Dave's patch with a testcase.
Functions with indirect calls must be transactified (transformed).

Tested on i686.
Ok for trunk?
--
Patrick

2012-05-15  Dave Boutcher  <daveboutcher@gmail.com>
             Patrick Marlier  <patrick.marlier@gmail.com>

         * trans-mem.c (ipa_tm_transform_clone): Transform functions with
         indirect calls.

2012-05-15  Patrick Marlier  <patrick.marlier@gmail.com>

         * gcc.dg/tm/indirect-2.c: New test.


On 05/08/2012 06:40 PM, Dave Boutcher wrote:
>   gcc/trans-mem.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/trans-mem.c b/gcc/trans-mem.c
> index 2badf25..24073fa 100644
> --- a/gcc/trans-mem.c
> +++ b/gcc/trans-mem.c
> @@ -4721,7 +4721,7 @@ ipa_tm_transform_clone (struct cgraph_node *node)
>     /* If this function makes no calls and has no irrevocable blocks,
>        then there's nothing to do.  */
>     /* ??? Remove non-aborting top-level transactions.  */
> -  if (!node->callees&&  !d->irrevocable_blocks_clone)
> +  if (!node->callees&&  !node->indirect_calls&& 
!d->irrevocable_blocks_clone)
>       return;
>
>     current_function_decl = d->clone->decl;

[rth_redhat.com, 2012-05-16 16:23:57]

On 05/15/2012 02:33 PM, Patrick Marlier wrote:
> 2012-05-15  Dave Boutcher <daveboutcher@gmail.com>
>              Patrick Marlier <patrick.marlier@gmail.com>
>
>          * trans-mem.c (ipa_tm_transform_clone): Transform functions with
>          indirect calls.
>
> 2012-05-15  Patrick Marlier <patrick.marlier@gmail.com>
>
>          * gcc.dg/tm/indirect-2.c: New test.

Ok for trunk and branch (if applicable).


r~