Issue 6194059: [google-4_6] fix profile mismatch in stream LIPO

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6194059: [google-4_6] fix profile mismatch in stream LIPO

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by xur

Modified:
12 years, 11 months ago

Reviewers:
davidxl

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_6/gcc/

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ipa-inline.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

xur

Hi, This patch is for google-4_6 branch only. It fixes a profile mismatch in streaming ...

12 years, 11 months ago (2012-05-08 16:53:46 UTC) #1

davidxl

12 years, 11 months ago (2012-05-08 16:55:28 UTC) #2

Ok.

David

On Tue, May 8, 2012 at 9:53 AM, Rong Xu <xur@google.com> wrote:
> Hi,
>
> This patch is for google-4_6 branch only.
>
> It fixes a profile mismatch in streaming LIPO and recovers the performance
loss
> due to this.
>
> Tested with google internal benchmarks.
>
> Thanks,
>
> 2012-05-08   Rong Xu  <xur@google.com>
>
>        * ipa-inline.c (fixed_arg_function_p):
>        (better_inline_comdat_function_p): match lipo_gen in stream LIPO.
>
> Index: ipa-inline.c
> ===================================================================
> --- ipa-inline.c        (revision 187275)
> +++ ipa-inline.c        (working copy)
> @@ -658,7 +658,7 @@ fixed_arg_function_p (tree fndecl)
>  static bool
>  better_inline_comdat_function_p (struct cgraph_node *node)
>  {
> -  return (profile_arc_flag && flag_dyn_ipa
> +  return (profile_arc_flag && (flag_dyn_ipa || flag_ripa_stream)
>           && DECL_COMDAT (node->decl)
>           && node->global.size <= PARAM_VALUE (PARAM_MAX_INLINE_INSNS_SINGLE)
>           && fixed_arg_function_p (node->decl));
>
> --
> This patch is available for review at http://codereview.appspot.com/6194059

Expand All Messages | Collapse All Messages