Issue 6190058: Print out posted data when XSRF token is invalid (issue361).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6190058: Print out posted data when XSRF token is invalid (issue361). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by Andi

Modified:
13 years, 11 months ago

Reviewers:
techtonik, GvR

Visibility:
Public.

More Reviews

Description

This is a quick workaround to make users happy for issue361. It shows the data posted to the server when an XSRF token becomes invalid. I'd leave the tracker issue open because it has some more advanced ideas to get rid of this problem.

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	codereview/views.py	View		1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

GvR

Looks good. I tested it (with a shorter timeout) and it does what it needs ...

14 years, 2 months ago (2012-05-08 17:19:27 UTC) #2

Andi Albrecht

14 years, 2 months ago (2012-05-08 18:57:46 UTC) #3

On 2012/05/08 17:19:27, GvR wrote:
> Looks good. I tested it (with a shorter timeout) and it does what it needs to
> do. HTML quoting looks good too.

Committed and live. Thanks for the review.

Expand All Messages | Collapse All Messages