Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(181)

Issue 6180044: code review 6180044: build: remove stray src/pkg/runtime/z* before build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by minux1
Modified:
11 years, 11 months ago
Reviewers:
CC:
golang-dev, bradfitz, dfc, rsc1, lstoakes, rsc
Visibility:
Public.

Description

cmd/dist: remove stray src/pkg/runtime/z* when cleaning

Patch Set 1 #

Patch Set 2 : diff -r 9f6d21a5b452 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9f6d21a5b452 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9f6d21a5b452 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/cmd/dist/build.c View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 11 months ago (2012-05-03 10:55:28 UTC) #1
bradfitz
LGTM On May 3, 2012 8:55 PM, <minux.ma@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: ...
11 years, 11 months ago (2012-05-03 11:21:49 UTC) #2
dfc
LGTM. Thanks. On 03/05/2012, at 20:55, minux.ma@gmail.com wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: > ...
11 years, 11 months ago (2012-05-03 11:26:19 UTC) #3
rsc1
Doesn't dist do this already?
11 years, 11 months ago (2012-05-03 12:08:45 UTC) #4
lstoakes
On 3 May 2012 13:08, Russ Cox <rsc@google.com> wrote: > Doesn't dist do this already? ...
11 years, 11 months ago (2012-05-03 12:13:11 UTC) #5
rsc1
On Thu, May 3, 2012 at 8:12 AM, Lorenzo Stoakes <lstoakes@gmail.com> wrote: > As a ...
11 years, 11 months ago (2012-05-03 12:45:39 UTC) #6
minux1
On Thu, May 3, 2012 at 8:45 PM, Russ Cox <rsc@google.com> wrote: > On Thu, ...
11 years, 11 months ago (2012-05-03 12:52:06 UTC) #7
rsc1
Okay, but even so it seems like dist should be the one removing these. The ...
11 years, 11 months ago (2012-05-03 12:54:51 UTC) #8
minux1
On 2012/05/03 12:54:51, rsc1 wrote: > Okay, but even so it seems like dist should ...
11 years, 11 months ago (2012-05-03 16:47:22 UTC) #9
rsc
LGTM Thanks!
11 years, 11 months ago (2012-05-03 16:48:29 UTC) #10
minux1
11 years, 11 months ago (2012-05-03 16:59:05 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=26fc3f8aa53e ***

cmd/dist: remove stray src/pkg/runtime/z* when cleaning

R=golang-dev, bradfitz, dave, rsc, lstoakes, rsc
CC=golang-dev
http://codereview.appspot.com/6180044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b