Issue 6149044: [google-4_6] fix undefined typeinfo reference in LIPO

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6149044: [google-4_6] fix undefined typeinfo reference in LIPO

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by xur

Modified:
12 years ago

Reviewers:
davidxl

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_6/

Visibility:
Public.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	gcc/cp/rtti.c	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

xur

Hi, This patch is for google-4_6 branch only. It fixes a undefined type-info reference in ...

12 years ago (2012-05-01 22:26:39 UTC) #1

davidxl

12 years ago (2012-05-01 22:32:13 UTC) #2

ok. Needs to be in google47 and google/main too.

David


On Tue, May 1, 2012 at 3:26 PM, Rong Xu <xur@google.com> wrote:
> Hi,
>
> This patch is for google-4_6 branch only.
>
> It fixes a undefined type-info reference in LIPO compilation.
>
> Tested with bootstrap, SPEC and internal benchmarks.
>
> Thanks,
>
> 2012-05-01   Rong Xu  <xur@google.com>
>
>        * gcc/cp/rtti.c (get_tinfo_decl): generate tinfo for aux
>        modules in LIPO.
>
> Index: gcc/cp/rtti.c
> ===================================================================
> --- gcc/cp/rtti.c       (revision 186884)
> +++ gcc/cp/rtti.c       (working copy)
> @@ -443,8 +443,7 @@ get_tinfo_decl (tree type)
>        CLASSTYPE_TYPEINFO_VAR (TYPE_MAIN_VARIANT (type)) = d;
>
>       /* Add decl to the global array of tinfo decls.  */
> -      if (!L_IPO_IS_AUXILIARY_MODULE)
> -        VEC_safe_push (tree, gc, unemitted_tinfo_decls, d);
> +      VEC_safe_push (tree, gc, unemitted_tinfo_decls, d);
>     }
>
>   return d;
>
> --
> This patch is available for review at http://codereview.appspot.com/6149044

Expand All Messages | Collapse All Messages