Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 6140045: Don't use virtual base classes without apparent reason (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dak
Modified:
11 years, 11 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Don't use virtual base classes without apparent reason Virtual base classes are a tool for joining the representations of common ancestors in a class lattice. They come at a cost in computational, conceptual, and usability complexity. I can't see the purpose for the instances of virtual inheritance in LilyPond (without multiple inheritance, there can't be much of an effect).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lily/include/engraver-group.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/global-context.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/performer-group.hh View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b