Issue 6133049: code review 6133049: misc/dashboard/codereview: don't depend on map iteratio...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6133049: code review 6133049: misc/dashboard/codereview: don't depend on map iteratio... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by dsymonds

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

misc/dashboard/codereview: don't depend on map iteration order for unit calculation. Fix auth requirements for /gc endpoint too.

Patch Set 1 #

Patch Set 2 : diff -r 26086374b931 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 26086374b931 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 26086374b931 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9d046474e95a https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	misc/dashboard/codereview/app.yaml	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	misc/dashboard/codereview/dashboard/cl.go	View	1	1 chunk	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-04-27 23:43:25 UTC) #1

dsymonds

On Sat, Apr 28, 2012 at 9:45 AM, <r@golang.org> wrote: > LGTM > ouch Yeah, ...

13 years, 2 months ago (2012-04-27 23:46:10 UTC) #4

dsymonds

13 years, 2 months ago (2012-04-27 23:47:28 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=d9a1980f5814 ***

misc/dashboard/codereview: don't depend on map iteration order for unit
calculation.

Fix auth requirements for /gc endpoint too.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6133049

Expand All Messages | Collapse All Messages