Issue 6131046: Generalizing dependencies instructions, removing json.jar and adding xpp3.jar

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6131046: Generalizing dependencies instructions, removing json.jar and adding xpp3.jar (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rmistry

Modified:
12 years ago

Reviewers:
yanivi

Base URL:
https://google-oauth-java-client.googlecode.com/hg/

Visibility:
Public.

Description

Fix for http://code.google.com/p/google-oauth-java-client/issues/detail?id=33 : Generalize dependencies instructions for non-Android

Patch Set 3 : Addressing code review comments #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -9 lines)			Patch
M	google-oauth-client-assembly/pom.xml	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	google-oauth-client-assembly/readme.html	View	1 2	1 chunk	+63 lines, -6 lines	0 comments	Download
M	pom.xml	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

yanivi

http://codereview.appspot.com/6131046/diff/2001/google-oauth-client-assembly/readme.html File google-oauth-client-assembly/readme.html (right): http://codereview.appspot.com/6131046/diff/2001/google-oauth-client-assembly/readme.html#newcode67 google-oauth-client-assembly/readme.html:67: <h3>Servlet Dependencies</h3> So for servlet, I think Apache HTTP ...

12 years ago (2012-04-30 16:55:46 UTC) #2

yanivi

by the way, perhaps we should make the same "Servlet Dependencies" section for google-http-client?

12 years ago (2012-04-30 16:56:45 UTC) #3

rmistry

12 years ago (2012-04-30 17:17:11 UTC) #4

rmistry

On 2012/04/30 16:56:45, yanivi wrote: > by the way, perhaps we should make the same ...

12 years ago (2012-04-30 17:17:21 UTC) #5

LGTM

Expand All Messages | Collapse All Messages