code review 6130050: go.crypto/ssh: add support for client side global requests

go.crypto/ssh: add support for client side global requests

* Add support for RFC4254 section 4 global requests.
* Improve clientConn.Listen to process responses properly.

[dave_cheney.net, 2012-04-29 05:18:47]

Hello agl@golang.org, gustav.paul@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[dave_cheney.net, 2012-04-29 05:21:52]

http://codereview.appspot.com/6130050/diff/5001/ssh/client.go
File ssh/client.go (right):

http://codereview.appspot.com/6130050/diff/5001/ssh/client.go#newcode29
ssh/client.go:29: 
This struct is an experiment in associating a lock with the thing that it locks.
Functionally there is no difference between placing these structs inside
ClientConn.

[agl1, 2012-04-30 14:31:11]

LGTM

http://codereview.appspot.com/6130050/diff/5001/ssh/client.go
File ssh/client.go (right):

http://codereview.appspot.com/6130050/diff/5001/ssh/client.go#newcode343
ssh/client.go:343: // in RFC4254 section 4. To correctly synchronise messages, a
lock
I think this note about the lock should be expanded to note that it's just a
simple way to ensure ordering, but that a pipelined solution would be faster.

[dave_cheney.net, 2012-04-30 22:04:25]

Hello agl@golang.org, gustav.paul@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[dave_cheney.net, 2012-04-30 22:07:56]

Thank you for your review. It should be possible to pipeline these messages in
the future, but global requests are not that common yet, in fact they we're
processed properly before this CL.

http://codereview.appspot.com/6130050/diff/5001/ssh/client.go
File ssh/client.go (right):

http://codereview.appspot.com/6130050/diff/5001/ssh/client.go#newcode343
ssh/client.go:343: // in RFC4254 section 4. To correctly synchronise messages, a
lock
On 2012/04/30 14:31:11, agl1 wrote:
> I think this note about the lock should be expanded to note that it's just a
> simple way to ensure ordering, but that a pipelined solution would be faster.

Done.

[agl1, 2012-04-30 22:11:31]

LGTM

[dave_cheney.net, 2012-04-30 22:12:30]

Thank you. If there are no more comments, I'll submit this later today.

[dave_cheney.net, 2012-05-01 05:44:08]

*** Submitted as
http://code.google.com/p/go/source/detail?r=71651a57184a&repo=crypto ***

go.crypto/ssh: add support for client side global requests

* Add support for RFC4254 section 4 global requests.
* Improve clientConn.Listen to process responses properly.

R=agl, gustav.paul
CC=golang-dev
http://codereview.appspot.com/6130050