Issue 6128054: code review 6128054: misc/dashboard/codereview: send mail to assigned review...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6128054: code review 6128054: misc/dashboard/codereview: send mail to assigned review... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by dsymonds

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, bradfitz, r

Visibility:
Public.

Description

misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in.

Patch Set 1 #

Patch Set 2 : diff -r d9a1980f5814 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d9a1980f5814 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d9a1980f5814 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 69c9477136d3 https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -7 lines)			Patch
	M	misc/dashboard/codereview/dashboard/cl.go	View	1 2 3 4	9 chunks	+97 lines, -4 lines	0 comments	Download
	M	misc/dashboard/codereview/dashboard/people.go	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-04-30 07:26:20 UTC) #1

bradfitz

LGTM On Mon, Apr 30, 2012 at 5:26 PM, <dsymonds@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...

13 years, 2 months ago (2012-04-30 07:32:39 UTC) #2

dsymonds

13 years, 2 months ago (2012-04-30 12:04:08 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=6a17ff5f4b33 ***

misc/dashboard/codereview: send mail to assigned reviewers if they aren't
already looped in.

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/6128054

Expand All Messages | Collapse All Messages