Issue 6127049: Fixed minor static anaylsis issues found by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6127049: Fixed minor static anaylsis issues found by cppcheck (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by robertphillips

Modified:
12 years ago

Reviewers:
Steve VanDeBogart, TomH, bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Fixed minor static anaylsis issues found by cppcheck

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -5 lines)			Patch
M	experimental/Networking/SkSockets.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFShader.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/glu/README.skia	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/glu/libtess/mesh.c	View	1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 7

bsalomon

Adding Mike and Steve as reviewers since I'm not familiar with these files. For GLU ...

12 years ago (2012-04-26 13:38:34 UTC) #2

bsalomon

Adding Mike and Steve as reviewers since I'm not familiar with these files. For GLU ...

12 years ago (2012-04-26 13:38:36 UTC) #3

bsalomon

On 2012/04/26 13:44:59, TomH wrote: > All LGTM. > (Brian, there's already a one-liner in ...

12 years ago (2012-04-26 23:28:01 UTC) #6

committed as r3771