Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(88)

Issue 6127049: Fixed minor static anaylsis issues found by cppcheck (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by robertphillips
Modified:
12 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixed minor static anaylsis issues found by cppcheck

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M experimental/Networking/SkSockets.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFShader.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/glu/README.skia View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/glu/libtess/mesh.c View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7
robertphillips
12 years, 7 months ago (2012-04-26 00:35:38 UTC) #1
bsalomon
Adding Mike and Steve as reviewers since I'm not familiar with these files. For GLU ...
12 years, 7 months ago (2012-04-26 13:38:34 UTC) #2
bsalomon
Adding Mike and Steve as reviewers since I'm not familiar with these files. For GLU ...
12 years, 7 months ago (2012-04-26 13:38:36 UTC) #3
TomH
All LGTM. (Brian, there's already a one-liner in the glu README?)
12 years, 7 months ago (2012-04-26 13:44:59 UTC) #4
Steve VanDeBogart
LGTM
12 years, 7 months ago (2012-04-26 16:40:41 UTC) #5
bsalomon
On 2012/04/26 13:44:59, TomH wrote: > All LGTM. > (Brian, there's already a one-liner in ...
12 years, 7 months ago (2012-04-26 23:28:01 UTC) #6
robertphillips
12 years, 7 months ago (2012-04-27 13:48:51 UTC) #7
committed as r3771
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b