Issue 6123059: [Issue 82] OutOfMemoryError with logging enabled

Issue 6123059: [Issue 82] OutOfMemoryError with logging enabled (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by yanivi

Modified:
12 years ago

Reviewers:
rmistry

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Patch Set 2 : merge & fix typo #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+418 lines, -139 lines)			Patch
M	google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java	View	1	4 chunks	+22 lines, -13 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java	View	1	5 chunks	+23 lines, -40 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/LogContent.java	View		3 chunks	+6 lines, -26 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/MultipartRelatedContent.java	View		3 chunks	+13 lines, -2 lines	0 comments	Download
A	google-http-client/src/main/java/com/google/api/client/util/LoggingByteArrayOutputStream.java	View		1 chunk	+136 lines, -0 lines	0 comments	Download
A	google-http-client/src/main/java/com/google/api/client/util/LoggingInputStream.java	View		1 chunk	+74 lines, -0 lines	0 comments	Download
A	google-http-client/src/main/java/com/google/api/client/util/LoggingOutputStream.java	View		1 chunk	+71 lines, -0 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java	View		4 chunks	+31 lines, -36 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java	View		7 chunks	+39 lines, -19 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rmistry

LGTM++ This is a very cool solution! http://codereview.appspot.com/6123059/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java (right): http://codereview.appspot.com/6123059/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java#newcode350 google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java:350: // logging ...

12 years ago (2012-04-27 12:47:18 UTC) #2

yanivi

12 years ago (2012-04-27 16:12:07 UTC) #4

http://codereview.appspot.com/6123059/diff/1/google-http-client/src/main/java...
File
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
(right):

http://codereview.appspot.com/6123059/diff/1/google-http-client/src/main/java...
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java:350:
// logging (wrap content with LogginInputStream)
On 2012/04/27 12:47:18, rmistry wrote:
> LogginInputStream -> LoggingInputStream

Done.

http://codereview.appspot.com/6123059/diff/1/google-http-client/src/main/java...
File
google-http-client/src/main/java/com/google/api/client/http/MultipartRelatedContent.java
(right):

http://codereview.appspot.com/6123059/diff/1/google-http-client/src/main/java...
google-http-client/src/main/java/com/google/api/client/http/MultipartRelatedContent.java:208:
private static boolean isTextBasedContentType(String contentType) {
On 2012/04/27 12:47:18, rmistry wrote:
> why static?

Static qualifier on methods is generally preferred over non-static in Java.

Expand All Messages | Collapse All Messages