code review 6117058: net/http: ignore paths on CONNECT requests in ServeMux

net/http: ignore paths on CONNECT requests in ServeMux

Fixes issue 3538

[bradfitz, 2012-04-25 18:23:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2012-04-25 18:34:13]

LGTM

it's not possible that anyone could rely on this behavior, is it?

[rsc, 2012-04-25 18:35:19]

NOT LGTM

[rsc, 2012-04-25 18:36:36]

I don't understand the description of this code.
You say that ServeMux doesn't support CONNECT
but you can connect to a path.  The rpc package
does exactly this.

Also, this is only disabling it for one redirect, not
in general.

I don't mind disabling the redirect, but the comment
does not reflect reality.

Russ

[bradfitz, 2012-04-25 19:09:17]

Hello golang-dev@googlegroups.com, adg@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-04-25 19:11:04]

okay, how about this version?

I didn't know about net/rpc using a path with CONNECT before.  (all.bash
passed, in any case.)

I also had forgotten that ServeMux can mux on hostnames (originally it only
did paths), so permitting a pathless CONNECT through (without error or
redirect) seems to make sense.


On Wed, Apr 25, 2012 at 12:09 PM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com, adg@golang.org, rsc@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**6117058/<http://codereview.appspot.com/6117058/>
>

[bradfitz, 2012-04-25 19:18:13]

Hello golang-dev@googlegroups.com, adg@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-04-25 19:44:00]

LGTM

[bradfitz, 2012-04-25 19:46:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=8eae6e390d20 ***

net/http: ignore paths on CONNECT requests in ServeMux

Fixes issue 3538

R=golang-dev, adg, rsc
CC=golang-dev
http://codereview.appspot.com/6117058