Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(894)

Issue 6115052: [google-4_6] fix broken -S in streaming LIPO

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by xur
Modified:
11 years, 12 months ago
Reviewers:
davidxl
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_6/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gcc/gcc.c View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
xur
Hi, This patch is for google-4_6 branch only. It fixes the broken -S in streaming ...
11 years, 12 months ago (2012-04-25 20:08:17 UTC) #1
davidxl
11 years, 12 months ago (2012-04-25 20:42:51 UTC) #2
ok.

David

On Wed, Apr 25, 2012 at 1:08 PM, Rong Xu <xur@google.com> wrote:
> Hi,
>
> This patch is for google-4_6 branch only.
> It fixes the broken -S in streaming LIPO mode.
>
> Tested with bootstrap.
>
> Thanks,
>
> 2012-04-25   Rong Xu  <xur@google.com>
>
>        * gcc/gcc.c (ripa_lto_spec): Support -S.
>        (cc1_options): Ditto.
>
> Index: gcc/gcc.c
> ===================================================================
> --- gcc/gcc.c   (revision 186783)
> +++ gcc/gcc.c   (working copy)
> @@ -746,7 +746,8 @@
>
>  /* specs to call lto1 for streaming lipo.  */
>  static const char *ripa_lto_spec =
> -"lto1 -flto -flto-partition=none %(cc1_options)";
> +"lto1 -flto -flto-partition=none %(cc1_options) "
> +"%{S:%W{o*}%{!o*:-o %b.s}}";
>
>  /* options to call asm in streaming lipo.  */
>  static const char *ripa_asm_options =
> @@ -820,7 +821,7 @@
>  %{-target-help:--target-help}\
>  %{-version:--version}\
>  %{-help=*:--help=%*}\
> - %{!fsyntax-only:%{S:%W{o*}%{!o*:-o %b.s}}}\
> + %{!fsyntax-only:%{S:%{!fripa=streaming|!fprofile-use*:%W{o*}%{!o*:-o
%b.s}}}}\
>  %{fsyntax-only:-o %j} %{-param*}\
>  %{fmudflap|fmudflapth:-fno-builtin -fno-merge-constants}\
>  %{coverage:-fprofile-arcs -ftest-coverage -fno-early-inlining}";
>
> --
> This patch is available for review at http://codereview.appspot.com/6115052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b