Use enum to set size of debug info generated by Clang"

This patch follows clattner's advice and introduces enum (instead of bool flags) that defines the size of debug info generated by Clang. This patch doesn't change the behavior and is a first step to introducing -gline-tables-only flag (http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120423/056674.html).

[chandlerc, 2012-04-26 17:10:54]

Mostly style nits. =] Once addressed, LGTM.

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGClass.cpp
File lib/CodeGen/CGClass.cpp (right):

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGClass.cpp#newcode1231
lib/CodeGen/CGClass.cpp:1231: CodeGenOptions::LimitedDebugInfo) {
Style nit: wrap this in parens if you want unusual indentation like this...

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp
File lib/CodeGen/CGExprScalar.cpp (right):

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp#new...
lib/CodeGen/CGExprScalar.cpp:805: CodeGenOptions::LimitedDebugInfo) {
Same comment here.

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp#new...
lib/CodeGen/CGExprScalar.cpp:809:
DI->getOrCreateRecordType(PTy->getPointeeType(),
Please try to avoid trimming trailing whitespace from lines you're not
changing... I only see the two here in this file, but wanted to mention it for
future reference.

http://codereview.appspot.com/6114059/diff/1/lib/Frontend/CompilerInvocation.cpp
File lib/Frontend/CompilerInvocation.cpp (right):

http://codereview.appspot.com/6114059/diff/1/lib/Frontend/CompilerInvocation....
lib/Frontend/CompilerInvocation.cpp:1100: Args.hasArg(OPT_flimit_debug_info))
There is a helper designed for this pattern: Args.hasFlag

[samsonov, 2012-04-27 07:25:03]

Commited as r155697, thank you!

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGClass.cpp
File lib/CodeGen/CGClass.cpp (right):

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGClass.cpp#newcode1231
lib/CodeGen/CGClass.cpp:1231: CodeGenOptions::LimitedDebugInfo) {
On 2012/04/26 17:10:54, chandlerc wrote:
> Style nit: wrap this in parens if you want unusual indentation like this...

Done (moved CGM.getCodeGenOpts()... to next line).

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp
File lib/CodeGen/CGExprScalar.cpp (right):

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp#new...
lib/CodeGen/CGExprScalar.cpp:805: CodeGenOptions::LimitedDebugInfo) {
On 2012/04/26 17:10:54, chandlerc wrote:
> Same comment here.

ditto

http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp#new...
lib/CodeGen/CGExprScalar.cpp:809:
DI->getOrCreateRecordType(PTy->getPointeeType(),
On 2012/04/26 17:10:54, chandlerc wrote:
> Please try to avoid trimming trailing whitespace from lines you're not
> changing... I only see the two here in this file, but wanted to mention it for
> future reference.

Ack.

http://codereview.appspot.com/6114059/diff/1/lib/Frontend/CompilerInvocation.cpp
File lib/Frontend/CompilerInvocation.cpp (right):

http://codereview.appspot.com/6114059/diff/1/lib/Frontend/CompilerInvocation....
lib/Frontend/CompilerInvocation.cpp:1100: Args.hasArg(OPT_flimit_debug_info))
On 2012/04/26 17:10:54, chandlerc wrote:
> There is a helper designed for this pattern: Args.hasFlag

Done.