Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267)

Issue 6108047: fix examples in cmd/venti

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by adk
Modified:
11 years, 11 months ago
Reviewers:
CC:
rsc, adkulkar_indiana.edu, codebot
Visibility:
Public.

Description

I am not entirely sure if this is the right fix, but the examples in cmd/venti return the error: "read count too large for protocol" This is because of the following check in vtreadpacket (libventi/client.c) which was added to support blocks > 64k: if(z->version[1] == '2' && n >= (1<<16)) { werrstr("read count too large for protocol"); return nil; } Setting VtMaxLumpSize to (1<<16)-1 fixes the issue.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/cmd/venti/copy.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/venti/dump.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/venti/read.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/venti/readfile.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/venti/readlist.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/venti/root.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/venti/write.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
adk
12 years ago (2012-04-23 16:33:16 UTC) #1
rsc
Thanks for this patch. Can you let me know your name for listing in the ...
12 years ago (2012-05-02 01:28:29 UTC) #2
adkulkar_indiana.edu
On Tue, May 1, 2012 at 7:28 PM, Russ Cox <rsc@golang.org> wrote: > Thanks for ...
12 years ago (2012-05-04 04:33:23 UTC) #3
rsc
11 years, 11 months ago (2012-05-29 17:34:58 UTC) #4
*** Submitted as http://code.google.com/p/plan9port/source/detail?r=1eb94efa54c9
***

venti: fix VtMaxLumpSize

R=rsc, adkulkar
CC=plan9port.codebot
http://codereview.appspot.com/6108047

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b