Issue 6100055: code review 6100055: test: test handling of negative float constants

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6100055: code review 6100055: test: test handling of negative float constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by iant

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

test: test handling of negative float constants This used to panic when compiled by gccgo. Updates issue 2876.

Patch Set 1 #

Patch Set 2 : diff -r 21264793e00f https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	A	test/fixedbugs/bug434.go	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-04-23 20:42:05 UTC) #1

rsc

LGTM maybe also add a var v := x b = math.Float64bits(-v) ... 6g used ...

13 years, 2 months ago (2012-04-23 20:48:10 UTC) #2

iant

13 years, 2 months ago (2012-04-23 22:47:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a3ef73ebec87 ***

test: test handling of negative float constants

This used to panic when compiled by gccgo.

Updates issue 2876.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6100055

Expand All Messages | Collapse All Messages