http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/website-work.itexi File Documentation/contributor/website-work.itexi (right): http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/website-work.itexi#newcode81 Documentation/contributor/website-work.itexi:81: Note that the website will fail to build if ...
12 years, 11 months ago
(2012-04-27 08:49:09 UTC)
#1
On 2012/04/27 08:49:09, Graham Percival wrote: > http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/website-work.itexi > File Documentation/contributor/website-work.itexi (right): > > http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/website-work.itexi#newcode81 ...
12 years, 11 months ago
(2012-04-27 15:01:23 UTC)
#2
On 2012/04/27 08:49:09, Graham Percival wrote:
>
http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/websit...
> File Documentation/contributor/website-work.itexi (right):
>
>
http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/websit...
> Documentation/contributor/website-work.itexi:81: Note that the website will
fail
> to build if you do not build it
> Everybody *should* be building it in a separate directory, but I still
consider
> it a bug that it doesn't work in the same directory. Is it just missing a
mkdir
> -p or something like that?
I think the problem is that it tries to do a blanket copy of everything from the
misc directory into the target directory, but if the build is not in a separate
build directory, then there will be "out/" in misc, which is a directory. If
there were a sort of "lazy" copy command (i.e. a copy that just failed silently
on directories instead of crashing) then it could be used instead.
On 2012/04/27 15:01:23, mike7 wrote: > I think the problem is that it tries to ...
12 years, 11 months ago
(2012-04-28 07:10:11 UTC)
#3
On 2012/04/27 15:01:23, mike7 wrote:
> I think the problem is that it tries to do a blanket copy of everything from
the
> misc directory into the target directory, but if the build is not in a
separate
> build directory, then there will be "out/" in misc, which is a directory.
Sounds like it could use an --exclude, then. Or a more explicit listing of
files in misc/.
Issue 6092045: Mentions separate build directory for website work
(Closed)
Created 12 years, 11 months ago by MikeSol
Modified 12 years, 4 months ago
Reviewers: Graham Percival, mike7
Base URL:
Comments: 1