Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(338)

Issue 6092045: Mentions separate build directory for website work (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by MikeSol
Modified:
11 years, 5 months ago
Reviewers:
Graham Percival, mike7
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Mentions separate build directory for website work

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M Documentation/contributor/website-work.itexi View 5 chunks +14 lines, -6 lines 1 comment Download

Messages

Total messages: 3
Graham Percival
http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/website-work.itexi File Documentation/contributor/website-work.itexi (right): http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/website-work.itexi#newcode81 Documentation/contributor/website-work.itexi:81: Note that the website will fail to build if ...
11 years, 12 months ago (2012-04-27 08:49:09 UTC) #1
mike7
On 2012/04/27 08:49:09, Graham Percival wrote: > http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/website-work.itexi > File Documentation/contributor/website-work.itexi (right): > > http://codereview.appspot.com/6092045/diff/1/Documentation/contributor/website-work.itexi#newcode81 ...
11 years, 12 months ago (2012-04-27 15:01:23 UTC) #2
Graham Percival
11 years, 12 months ago (2012-04-28 07:10:11 UTC) #3
On 2012/04/27 15:01:23, mike7 wrote:
> I think the problem is that it tries to do a blanket copy of everything from
the
> misc directory into the target directory, but if the build is not in a
separate
> build directory, then there will be "out/" in misc, which is a directory.

Sounds like it could use an --exclude, then.  Or a more explicit listing of
files in misc/.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b