Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15479)

Issue 6088043: Turn off retry handling in the default apache HTTP client (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by rmistry
Modified:
12 years ago
Reviewers:
yanivi
Base URL:
https://google-http-java-client.googlecode.com/hg/
Visibility:
Public.

Description

Fix for http://code.google.com/p/google-http-java-client/issues/detail?id=56 : NonRepeatableRequestException when using Apache HTTP Client I also took a look at NetHttpTransport and does not look like it has any retry mechanism turned on by default.

Patch Set 1 #

Patch Set 2 : Minor fix #

Patch Set 3 : Minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpTransport.java View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/apache/ApacheHttpTransportTest.java View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2
rmistry
12 years ago (2012-04-20 16:19:10 UTC) #1
yanivi
12 years ago (2012-04-20 16:52:55 UTC) #2
LGTM

Note that we call "connection.setInstanceFollowRedirects(false);" in
NetHttpRequest.java line 39, so NetHttpTransport is good.

For UrlFetchTransport, in UrlFetchRequest.java lines 38-44, we call:

  private static final FetchOptions OPTIONS =
     
FetchOptions.Builder.doNotFollowRedirects().disallowTruncate().validateCertificate();
...
    request = new HTTPRequest(new URL(url), method, OPTIONS);

so we're good there too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b