net/http/httputil: Made reverseproxy test less flaky.

net/http/httputil: Made reverseproxy test less flaky.

The reverseproxy test depended on the behavior of
runtime.NumGoroutines(), which makes no guarantee when
goroutines are reaped. Instead, modify the flushLoop()
to invoke a callback when it returns, so the exit
from the loop can be tested, instead of the number
of gorountines running.

[bradfitz, 2012-04-19 18:50:57]

Yeah, this seems like a better test.

http://codereview.appspot.com/6068046/diff/2001/src/pkg/net/http/httputil/rev...
File src/pkg/net/http/httputil/reverseproxy_test.go (right):

http://codereview.appspot.com/6068046/diff/2001/src/pkg/net/http/httputil/rev...
src/pkg/net/http/httputil/reverseproxy_test.go:138: for i := 0; i < 10; i++ {
you can remove the test short check now.

also, you probably don't even need to do 10 here... 1 seems sufficient.

http://codereview.appspot.com/6068046/diff/2001/src/pkg/net/http/httputil/rev...
src/pkg/net/http/httputil/reverseproxy_test.go:152: case <-time.After(100 *
time.Millisecond):
this is way too small for our poor little ARM machines.

Just do 5 seconds here.

[cranger, 2012-04-19 19:14:13]

http://codereview.appspot.com/6068046/diff/2001/src/pkg/net/http/httputil/rev...
File src/pkg/net/http/httputil/reverseproxy_test.go (right):

http://codereview.appspot.com/6068046/diff/2001/src/pkg/net/http/httputil/rev...
src/pkg/net/http/httputil/reverseproxy_test.go:138: for i := 0; i < 10; i++ {
On 2012/04/19 18:50:57, bradfitz wrote:
> you can remove the test short check now.
> 
> also, you probably don't even need to do 10 here... 1 seems sufficient.

Done.

http://codereview.appspot.com/6068046/diff/2001/src/pkg/net/http/httputil/rev...
src/pkg/net/http/httputil/reverseproxy_test.go:152: case <-time.After(100 *
time.Millisecond):
On 2012/04/19 18:50:57, bradfitz wrote:
> this is way too small for our poor little ARM machines.
> 
> Just do 5 seconds here.

Done.

[bradfitz, 2012-04-20 16:30:57]

LGTM

[bradfitz, 2012-04-20 16:31:14]

LGTM

[bradfitz, 2012-04-20 16:31:29]

*** Submitted as http://code.google.com/p/go/source/detail?r=67c9d67aa825 ***

net/http/httputil: Made reverseproxy test less flaky.

The reverseproxy test depended on the behavior of
runtime.NumGoroutines(), which makes no guarantee when
goroutines are reaped. Instead, modify the flushLoop()
to invoke a callback when it returns, so the exit
from the loop can be tested, instead of the number
of gorountines running.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/6068046

Committer: Brad Fitzpatrick <bradfitz@golang.org>