Issue 6060048: code review 6060048: exp/html: add parseImpliedToken method to parser

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6060048: code review 6060048: exp/html: add parseImpliedToken method to parser (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by andybalholm

Modified:
13 years, 3 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

exp/html: add parseImpliedToken method to parser This method will allow us to be explicit about what we're doing when we insert an implied token, and avoid repeating the logic involved in multiple places.

Patch Set 1 #

Patch Set 2 : diff -r 85809ed633b5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 85809ed633b5 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -37 lines)			Patch
	M	src/pkg/exp/html/parse.go	View	1	6 chunks	+47 lines, -37 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, nigeltao@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-04-18 16:21:03 UTC) #1

nigeltao

13 years, 3 months ago (2012-04-19 01:48:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6c3ed145bf76 ***

exp/html: add parseImpliedToken method to parser

This method will allow us to be explicit about what we're doing when
we insert an implied token, and avoid repeating the logic involved in
multiple places.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/6060048

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages