code review 6051044: flag: update style.

flag: update style.

[dsymonds, 2012-04-17 04:02:36]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-04-17 04:04:30]

That was deliberate, so the type is clear. Otherwise it's not obvious
from the code that those are pointers.

[dsymonds, 2012-04-17 05:21:16]

On Tue, Apr 17, 2012 at 2:04 PM, Rob 'Commander' Pike <r@golang.org> wrote:

> That was deliberate, so the type is clear. Otherwise it's not obvious
> from the code that those are pointers.

Sure, but it's odd that we recommend people to not use the type in
their own code. This doc is setting a bad example. What if there was a
comment instead?
  // ip is a *int

[r2, 2012-04-17 06:08:16]

On Apr 17, 2012, at 3:21 PM, David Symonds wrote:

> On Tue, Apr 17, 2012 at 2:04 PM, Rob 'Commander' Pike <r@golang.org> wrote:
> 
>> That was deliberate, so the type is clear. Otherwise it's not obvious
>> from the code that those are pointers.
> 
> Sure, but it's odd that we recommend people to not use the type in
> their own code. This doc is setting a bad example. What if there was a
> comment instead?
>  // ip is a *int

write it and we'll see how it looks.

-rob

[dsymonds, 2012-04-17 06:14:40]

Hello golang-dev@googlegroups.com, r@golang.org, r@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-04-17 06:20:10]

http://codereview.appspot.com/6051044/diff/3002/src/pkg/flag/flag.go
File src/pkg/flag/flag.go (right):

http://codereview.appspot.com/6051044/diff/3002/src/pkg/flag/flag.go#newcode12
src/pkg/flag/flag.go:12: var ip = flag.Int("flagname", 1234, "help message for
flagname") // ip is *int
it's hidden over there.
how about
This declares an integer flag, -flagname, stored in the pointer ip, with type
*int.

[dsymonds, 2012-04-17 06:31:20]

Hello golang-dev@googlegroups.com, r@golang.org, r@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-04-17 06:31:40]

http://codereview.appspot.com/6051044/diff/3002/src/pkg/flag/flag.go
File src/pkg/flag/flag.go (right):

http://codereview.appspot.com/6051044/diff/3002/src/pkg/flag/flag.go#newcode12
src/pkg/flag/flag.go:12: var ip = flag.Int("flagname", 1234, "help message for
flagname") // ip is *int
On 2012/04/17 06:20:10, r wrote:
> it's hidden over there.
> how about
> This declares an integer flag, -flagname, stored in the pointer ip, with type
> *int.

Done.

[r, 2012-04-17 06:33:56]

LGTM

[dsymonds, 2012-04-17 06:37:44]

*** Submitted as http://code.google.com/p/go/source/detail?r=059ba0d0dc6a ***

flag: update style.

R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/6051044