Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2980)

Issue 6050054: Implemented SSE2 version of loadAlphaData (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by Jin Yang
Modified:
11 years, 11 months ago
Reviewers:
dgkoch, nicolas
Base URL:
http://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

With this patch,my HTML5 2D canvas benchmark with Chromium on Windows7 with GPU acceleration can boost about 4% though the most execution time is in GPU.

Patch Set 1 #

Patch Set 2 : correct the format #

Total comments: 6

Patch Set 3 : patch 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
src/libGLESv2/Texture.h View 1 chunk +2 lines, -0 lines 0 comments Download
src/libGLESv2/Texture.cpp View 1 2 3 chunks +49 lines, -2 lines 0 comments Download

Messages

Total messages: 11
Jin Yang
11 years, 11 months ago (2012-04-18 12:49:27 UTC) #1
dgkoch
Thanks for contributing! I noticed there seems to be some formatting issues -- likely caused ...
11 years, 11 months ago (2012-04-18 13:21:59 UTC) #2
Jin Yang
correct the format
11 years, 11 months ago (2012-04-18 13:24:15 UTC) #3
Jin Yang
Hi nicolas, Please help review it when you are available. Thanks, Jin
11 years, 11 months ago (2012-04-20 05:56:08 UTC) #4
nicolas
Spotted a little bug and an easy optimization. http://codereview.appspot.com/6050054/diff/5001/src/libGLESv2/Texture.cpp File src/libGLESv2/Texture.cpp (right): http://codereview.appspot.com/6050054/diff/5001/src/libGLESv2/Texture.cpp#newcode455 src/libGLESv2/Texture.cpp:455: dest[x] ...
11 years, 11 months ago (2012-04-20 13:06:31 UTC) #5
Jin Yang
patch 3
11 years, 11 months ago (2012-04-24 02:29:04 UTC) #6
Jin Yang
Thanks for your nice comments! I have fixed them in the new patch. Jin http://codereview.appspot.com/6050054/diff/5001/src/libGLESv2/Texture.cpp ...
11 years, 11 months ago (2012-04-24 02:30:50 UTC) #7
nicolas
Looks good to me. By the way, have you tried optimizing the non-SSE2 version by ...
11 years, 11 months ago (2012-04-24 19:43:39 UTC) #8
Jin Yang
On 2012/04/24 19:43:39, nicolas wrote: > Looks good to me. > > By the way, ...
11 years, 11 months ago (2012-04-25 02:23:54 UTC) #9
Jin Yang
Is it possible to commit the patch into the repo? Thanks
11 years, 11 months ago (2012-04-28 03:37:58 UTC) #10
dgkoch
11 years, 11 months ago (2012-05-01 15:27:30 UTC) #11
On 2012/04/28 03:37:58, Jin Yang wrote:
> Is it possible to commit the patch into the repo? Thanks

Committed to ANGLE as r1067:
http://code.google.com/p/angleproject/source/detail?r=1067
(you'll have to manually close this review)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b