code review 604043: libmach: more info when memory reads fail on Darwin

libmach: more info when memory reads fail on Darwin

[rsc, 2010-03-19 23:28:42]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-03-19 23:29:47]

LGTM

On Mar 19, 2010, at 4:28 PM, rsc@golang.org wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> libmach: more info when memory reads fail on Darwin
>
> Please review this at http://codereview.appspot.com/604043/show
>
> Affected files:
>  M src/libmach/darwin.c
>
>
> Index: src/libmach/darwin.c
> ===================================================================
> --- a/src/libmach/darwin.c
> +++ b/src/libmach/darwin.c
> @@ -156,7 +156,7 @@
>
> 	for(i=0; i<nelem(macherr); i++){
> 		if(r == macherr[i].code){
> -			werrstr("%s", macherr[i].name);
> +			werrstr("mach: %s", macherr[i].name);
> 			return -1;
> 		}
> 	}
> @@ -408,8 +408,10 @@
> 	if(isr){
> 		vm_size_t nn;
> 		nn = n;
> -		if(me(vm_read_overwrite(task, addr, n, (uintptr)v, &nn)) < 0)
> +		if(me(vm_read_overwrite(task, addr, n, (uintptr)v, &nn)) < 0) {
> +			fprint(2, "vm_read_overwrite %#llux %d to %p: %r\n", addr, n, v);
> 			return -1;
> +		}
> 		return nn;
> 	}else{
> 		r = vm_write(task, addr, (uintptr)v, n);
>
>

[r, 2010-03-20 00:07:13]

LGTM

[rsc, 2010-03-21 05:37:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=58d385f38228 ***

libmach: more info when memory reads fail on Darwin

R=r
CC=golang-dev
http://codereview.appspot.com/604043