Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1404)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6032043: Minor code cleanup to Debug GL Interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by robertphillips
Modified:
12 years ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Moved some methods to empty .cpp files Fixed some indenting issues in headers disallowed copy constructor & assignment operator Enforced 80 character line length limit in some places

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -91 lines) Patch
M gyp/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/debug/GrBufferObj.h View 1 2 chunks +14 lines, -31 lines 0 comments Download
M src/gpu/gl/debug/GrBufferObj.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/GrFakeRefObj.h View 1 5 chunks +13 lines, -11 lines 0 comments Download
D src/gpu/gl/debug/GrFakeRefObj.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/gpu/gl/debug/GrProgramObj.h View 1 chunk +27 lines, -27 lines 0 comments Download
M src/gpu/gl/debug/GrShaderObj.h View 1 1 chunk +4 lines, -7 lines 0 comments Download
M src/gpu/gl/debug/GrShaderObj.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/GrTextureObj.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/gl/debug/GrTextureObj.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5
robertphillips
12 years ago (2012-04-13 18:22:09 UTC) #1
bsalomon
http://codereview.appspot.com/6032043/diff/1/src/gpu/gl/debug/GrFakeRefObj.h File src/gpu/gl/debug/GrFakeRefObj.h (right): http://codereview.appspot.com/6032043/diff/1/src/gpu/gl/debug/GrFakeRefObj.h#newcode14 src/gpu/gl/debug/GrFakeRefObj.h:14: #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ Would subclassing GrFakeRefObj from GrNoncopyable work?
12 years ago (2012-04-16 14:46:25 UTC) #2
robertphillips
http://codereview.appspot.com/6032043/diff/1/src/gpu/gl/debug/GrFakeRefObj.h File src/gpu/gl/debug/GrFakeRefObj.h (right): http://codereview.appspot.com/6032043/diff/1/src/gpu/gl/debug/GrFakeRefObj.h#newcode14 src/gpu/gl/debug/GrFakeRefObj.h:14: #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ On 2012/04/16 14:46:25, bsalomon wrote: > ...
12 years ago (2012-04-16 15:40:43 UTC) #3
bsalomon
On 2012/04/16 15:40:43, robertphillips wrote: > http://codereview.appspot.com/6032043/diff/1/src/gpu/gl/debug/GrFakeRefObj.h > File src/gpu/gl/debug/GrFakeRefObj.h (right): > > http://codereview.appspot.com/6032043/diff/1/src/gpu/gl/debug/GrFakeRefObj.h#newcode14 > ...
12 years ago (2012-04-16 15:52:50 UTC) #4
robertphillips
12 years ago (2012-04-16 16:25:03 UTC) #5 
committed as r3690
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b