Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(114)

Issue 601042: code review 601042: godoc: improved comment formatting: recognize URLs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by gri
Modified:
15 years, 4 months ago
Reviewers:
CC:
rsc, adg, golang-dev
Visibility:
Public.

Description

godoc: improved comment formatting: recognize URLs and highlight special words, if provided. Also: - related cleanups in src/pkg/go/doc/comment.go - fix typos in src/cmd/goinstall/doc.go Fixes issue 672.

Patch Set 1 #

Patch Set 2 : code review 601042: godoc: improved comment formatting: recognize URLs #

Patch Set 3 : code review 601042: godoc: improved comment formatting: recognize URLs #

Patch Set 4 : code review 601042: godoc: improved comment formatting: recognize URLs #

Patch Set 5 : code review 601042: godoc: improved comment formatting: recognize URLs #

Patch Set 6 : code review 601042: godoc: improved comment formatting: recognize URLs #

Patch Set 7 : code review 601042: godoc: improved comment formatting: recognize URLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -41 lines) Patch
M src/cmd/godoc/godoc.go View 1 chunk +3 lines, -1 line 0 comments Download
M src/cmd/goinstall/doc.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/doc/comment.go View 1 2 3 8 chunks +135 lines, -39 lines 0 comments Download

Messages

Total messages: 5
gri
Hello rsc (cc: adg, golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 4 months ago (2010-03-18 00:06:01 UTC) #1
gri
Hello rsc (cc: adg, golang-dev@googlegroups.com), Please take another look.
15 years, 4 months ago (2010-03-18 20:05:04 UTC) #2
rsc
LGTM nice. thanks for closing that todo.
15 years, 4 months ago (2010-03-19 19:48:41 UTC) #3
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=89a95c327ef2 *** godoc: improved comment formatting: recognize URLs and highlight special words, ...
15 years, 4 months ago (2010-03-19 20:02:01 UTC) #4
adg
15 years, 4 months ago (2010-03-19 21:38:29 UTC) #5
Very quick turnaround. Thanks Robert. :-)

On 20 Mar 2010 06:48, <rsc@golang.org> wrote:

LGTM

nice.  thanks for closing that todo.




http://codereview.appspot.com/601042/show
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b