UV Offset Modifier

[ideasman42, 2012-04-07 05:48:07]

Submitting this patch on behalf of the original author - see:

http://kompak.pl/index.php?id=28

also see:
http://blenderartists.org/forum/showthread.php?245828-UV-Offset-modifier/page2

Would be good if these can be addressed so the patch can be committed into trunk
right after release.

http://codereview.appspot.com/5991062/diff/1/release/scripts/startup/bl_ui/pr...
File release/scripts/startup/bl_ui/properties_data_modifier.py (right):

http://codereview.appspot.com/5991062/diff/1/release/scripts/startup/bl_ui/pr...
release/scripts/startup/bl_ui/properties_data_modifier.py:972: if md.target.type
== 'ARMATURE':
shouldnt 'if md.target is not None:' be checkled here?

http://codereview.appspot.com/5991062/diff/1/source/blender/makesdna/DNA_modi...
File source/blender/makesdna/DNA_modifier_types.h (right):

http://codereview.appspot.com/5991062/diff/1/source/blender/makesdna/DNA_modi...
source/blender/makesdna/DNA_modifier_types.h:1071: 
would prefer 'float offset[2]' here rather then x/y, so 2D BLI_math functions
can be used which operate on 2D vectors.

http://codereview.appspot.com/5991062/diff/1/source/blender/makesrna/intern/r...
File source/blender/makesrna/intern/rna_modifier.c (right):

http://codereview.appspot.com/5991062/diff/1/source/blender/makesrna/intern/r...
source/blender/makesrna/intern/rna_modifier.c:2641: 
again, prefer 2d vector over X/Y

http://codereview.appspot.com/5991062/diff/1/source/blender/modifiers/intern/...
File source/blender/modifiers/intern/MOD_uvoffset.c (right):

http://codereview.appspot.com/5991062/diff/1/source/blender/modifiers/intern/...
source/blender/modifiers/intern/MOD_uvoffset.c:103: u =
pchan->loc[0];//chan_mat[3][0];
->loc is the input location of the pose channel (before drivers/constraints),
best use the 'matrix[3]' which is the final pose location of the bone.

Also, the location should be relative to the 'ob', otherwise dragging both
objects wont keep their relative locations.

so! - suggest to multiply the pose matrix by the 'ob's inverted matrix. Then you
can use the matrix[3] of the resulting matrix.

After this is done, you may want to have an option to choose which axis to use
(X-Y, X-Z, Y-Z) as well as a swap boolean (to get Y-X, Z-X) ... etc - May as
well allow any combination.

If all this sounds confusing... its not really hard to add and I can help with
it.

http://codereview.appspot.com/5991062/diff/1/source/blender/modifiers/intern/...
source/blender/modifiers/intern/MOD_uvoffset.c:107: u = umd->target->loc[0];
same comment as above applies - though the code need not be duplicated - just
have a function that takes 2 matrix, some axis options and initializes a 2D
offset.

http://codereview.appspot.com/5991062/diff/1/source/blender/modifiers/intern/...
source/blender/modifiers/intern/MOD_uvoffset.c:140: 
dm->dirty |= DM_DIRTY_TESS_CDLAYERS;
 should be called here so tessface UV's are updated.

[ideasman42, 2012-04-07 07:07:13]

forgot to set bf-codereview as reviewer.