Supporting UnsignedInteger and UnsignedLong as primitive numeric types

Fix for [Issue 59]: UnsignedLong and UnsignedInteger

[yanivi, 2012-04-16 17:51:30]

a few minor comments...

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java
(right):

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java:89:
/** Writes a JSON unsigned integer value. */
same comments as in JsonParser

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
File google-http-client/src/main/java/com/google/api/client/json/JsonParser.java
(right):

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/json/JsonParser.java:111:
/** Returns the {@link UnsignedInteger} value of the current token. */
@since 1.9
similarly below

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/json/JsonParser.java:112:
public abstract UnsignedInteger getUnsignedIntegerValue() throws IOException;
Since this is a backwards-incompatible change, please add a JavaDoc comment that
warns about this change, preferably at the class level.

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
File google-http-client/src/main/java/com/google/api/client/util/Data.java
(right):

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/util/Data.java:46: public
class Data {
please also update DataTest and FieldInfoTest
we should probably move testParsePrimitiveValue from the latter to the former.

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/util/Data.java:81: public
static final UnsignedInteger NULL_UNSIGNED_INTEGER =
UnsignedInteger.valueOf("0");
[optional] a bit simpler to call UnsignedInteger.asUnsigned(0)

similarly for line 84

[rmistry, 2012-04-18 14:50:58]

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java
(right):

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java:89:
/** Writes a JSON unsigned integer value. */
On 2012/04/16 17:51:30, yanivi wrote:
> same comments as in JsonParser

Done.

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
File google-http-client/src/main/java/com/google/api/client/json/JsonParser.java
(right):

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/json/JsonParser.java:111:
/** Returns the {@link UnsignedInteger} value of the current token. */
On 2012/04/16 17:51:30, yanivi wrote:
> @since 1.9
> similarly below

Done.

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/json/JsonParser.java:112:
public abstract UnsignedInteger getUnsignedIntegerValue() throws IOException;
On 2012/04/16 17:51:30, yanivi wrote:
> Since this is a backwards-incompatible change, please add a JavaDoc comment
that
> warns about this change, preferably at the class level.

Done.

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
File google-http-client/src/main/java/com/google/api/client/util/Data.java
(right):

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/util/Data.java:46: public
class Data {
On 2012/04/16 17:51:30, yanivi wrote:
> please also update DataTest and FieldInfoTest
> we should probably move testParsePrimitiveValue from the latter to the former.

Done.

http://codereview.appspot.com/5987055/diff/1013/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/util/Data.java:81: public
static final UnsignedInteger NULL_UNSIGNED_INTEGER =
UnsignedInteger.valueOf("0");
On 2012/04/16 17:51:30, yanivi wrote:
> [optional] a bit simpler to call UnsignedInteger.asUnsigned(0)
> 
> similarly for line 84

Done.

[yanivi, 2012-04-19 19:35:33]

LGTM