code review 5986043: misc/dist: label 386 and amd64 as "32-bit x86" and "64-...

misc/dist: label 386 and amd64 as "32-bit x86" and "64-bit x86"

[adg, 2012-04-05 01:07:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitz, 2012-04-05 01:11:08]

LGTM

On Wed, Apr 4, 2012 at 6:07 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> misc/dist: label 386 and amd64 as "32-bit x86" and "64-bit x86"
>
> Please review this at
http://codereview.appspot.com/**5986043/<http://codereview.appspot.com/5986043/>
>
> Affected files:
>  M misc/dist/bindist.go
>
>
> Index: misc/dist/bindist.go
> ==============================**==============================**=======
> --- a/misc/dist/bindist.go
> +++ b/misc/dist/bindist.go
> @@ -394,9 +394,9 @@
>        os_, arch := b.OS, b.Arch
>        switch b.Arch {
>        case "386":
> -               arch = "32-bit"
> +               arch = "x86 32-bit"
>        case "amd64":
> -               arch = "64-bit"
> +               arch = "x86 64-bit"
>        }
>        if arch != "" {
>                labels = append(labels, "Arch-"+b.Arch)
>
>
>

[adg, 2012-04-05 01:16:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=bf6abd131308 ***

misc/dist: label 386 and amd64 as "32-bit x86" and "64-bit x86"

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5986043