Issue 5975065: Popup menu layout inherits context store from button

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5975065: Popup menu layout inherits context store from button (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by lukas.toenne

Modified:
12 years, 1 month ago

Reviewers:
brechtvl, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

This is my attempt to solve a problem i had with operator menus. I am using uiLayoutSetContextPointer to add the bNode pointer to the draw context in nodes, so operator buttons can work on a specific node (similarly used in modifiers and logic bricks). Problem is that, while it works nicely for standard buttons, it fails to pass the context pointer to popup menu layouts. This patch copies the bContextStore from the original uiBut to the new popup layout. @Brecht: Campbell told me you implemented this feature in the first place, so would be nice if you could review.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+42 lines, -2 lines)			Patch
source/blender/blenkernel/BKE_context.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
source/blender/blenkernel/intern/context.c	View	1 chunk	+29 lines, -0 lines	0 comments	Download
source/blender/editors/include/UI_interface.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
source/blender/editors/interface/interface_layout.c	View	1 chunk	+6 lines, -0 lines	0 comments	Download
source/blender/editors/interface/interface_regions.c	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM.

Expand All Messages | Collapse All Messages