Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(529)

Issue 5970073: File output, node RNA and context changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by lukas.toenne
Modified:
12 years ago
Reviewers:
brechtvl, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

A number of changes to node RNA and the file output node, to simplify socket types and make node code more robust for future nodes with extra socket data. * Removed the struct_type identifier from sockets completely. Any specialization of socket types can be done by using separate collections in RNA and customized socket draw callbacks in node type. Sockets themselves are pure data inputs/outputs now. Possibly the sock->storage data could also be removed, but this will change anyway with id properties in custom nodes. * Replaced the direct socket button draw calls by extra callbacks in node types. This allows nodes to draw sockets in specialized ways without referring to the additional struct_type identifier. Default is simply drawing the socket default_value button, only file output node overrides this atm. * File output node slots now use a separate file sub-path in their storage data, instead of using the socket name. That way the path is an actual PROP_FILEPATH property and it works better with the UI list template (name property is local to the data struct). * Node draw contexts for options on the node itself and detail buttons in the sidebar now have an extra context pointer "node" (uiLayoutSetContextPointer). This can be used to bind operator buttons to a specific node, instead of having to rely on the active/selected node(s) or making weak links via node name. Compare to modifiers and logic bricks, they use the same feature. * Added another operator for reordering custom input slots in the file output node.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -203 lines) Patch
source/blender/blenkernel/BKE_node.h View 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/blenloader/intern/readfile.c View 2 chunks +34 lines, -4 lines 0 comments Download
source/blender/editors/space_node/drawnode.c View 8 chunks +130 lines, -118 lines 0 comments Download
source/blender/editors/space_node/node_buttons.c View 2 chunks +5 lines, -1 line 0 comments Download
source/blender/editors/space_node/node_draw.c View 2 chunks +5 lines, -21 lines 0 comments Download
source/blender/editors/space_node/node_edit.c View 3 chunks +78 lines, -6 lines 0 comments Download
source/blender/editors/space_node/node_intern.h View 1 chunk +1 line, -0 lines 0 comments Download
source/blender/editors/space_node/node_ops.c View 1 chunk +1 line, -0 lines 0 comments Download
source/blender/makesdna/DNA_node_types.h View 4 chunks +3 lines, -6 lines 0 comments Download
source/blender/makesrna/intern/rna_nodetree.c View 5 chunks +41 lines, -42 lines 0 comments Download
source/blender/nodes/composite/nodes/node_composite_outputFile.c View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 2
lukas.toenne
12 years, 1 month ago (2012-04-03 15:12:57 UTC) #1
brechtvl
12 years, 1 month ago (2012-04-03 15:36:44 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b