Issue 5969063: code review 5969063: godoc: update appinit.go, apply !appengine build constr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5969063: code review 5969063: godoc: update appinit.go, apply !appengine build constr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by minux1

Modified:
13 years, 4 months ago

Reviewers:

CC:
adg, dsymonds, golang-dev

Visibility:
Public.

Description

godoc: update appinit.go, apply !appengine build constrain to main.go

Patch Set 1 #

Patch Set 2 : diff -r 8434de733c20 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 95e67cc5fa08 https://code.google.com/p/go/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/cmd/godoc/appinit.go	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
	M	src/cmd/godoc/main.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello adg@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 4 months ago (2012-04-02 07:23:14 UTC) #1

adg

LGTM We really should add a test for the app engine component of this to ...

13 years, 4 months ago (2012-04-02 21:19:24 UTC) #3

minux1

13 years, 4 months ago (2012-04-03 16:00:39 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c7988b3a8341 ***

godoc: update appinit.go, apply !appengine build constrain to main.go

R=adg, dsymonds
CC=golang-dev
http://codereview.appspot.com/5969063

Expand All Messages | Collapse All Messages