Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(704)

Issue 5969060: Doc: NR 1.8.2 - add \abs-fontsize to main doc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by pkx166h
Modified:
12 years ago
Reviewers:
Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR 1.8.2 - add \abs-fontsize to main doc Issue 2435 Updated examples with clearer explanations/examples and included \abs-fontsize as an @lilypond added @funindex for \abs-fontsize

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M Documentation/notation/text.itely View 2 chunks +31 lines, -28 lines 2 comments Download

Messages

Total messages: 2
Trevor Daniels
LGTM, apart from the one change suggested. Trevor http://codereview.appspot.com/5969060/diff/2001/Documentation/notation/text.itely File Documentation/notation/text.itely (right): http://codereview.appspot.com/5969060/diff/2001/Documentation/notation/text.itely#newcode544 Documentation/notation/text.itely:544: It ...
12 years ago (2012-04-01 22:25:17 UTC) #1
pkx166h
12 years ago (2012-04-08 11:18:08 UTC) #2
committer	James Lowe <pkx166h@gmail.com>	
Sun, 8 Apr 2012 11:14:39 +0000 (12:14 +0100)
commit	dd8a0b7cc3280f273e66d20c72f1d4097dc6645a

Pushed as that had had a 'push' approval from GP and the additional corrections
from TD were trivial.

http://codereview.appspot.com/5969060/diff/2001/Documentation/notation/text.i...
File Documentation/notation/text.itely (right):

http://codereview.appspot.com/5969060/diff/2001/Documentation/notation/text.i...
Documentation/notation/text.itely:544: It can be set to a fixed value,
On 2012/04/01 22:25:17, Trevor Daniels wrote:
> Better to re-emphasize this is _relative_ to the value set by the global staff
> size, perhaps by saying, "It can be increased or decreased relative to the
value
> set by the global staff size,"  Maybe include \fontsize #-2 in the example
below
> to show sizes smaller than that set by the global staff size can be specified.


Done.

I also swapped the order of the examples round (no other changes) so that it was
more natural a progression in describing what was changing in each case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b