code review 593043: version.bash: cope with ancient Mercurial

version.bash: cope with ancient Mercurial

[rsc, 2010-03-16 20:58:49]

Hello adg (cc: dpx, golang-dev@googlegroups.com),

I'd like you to review this change.

[adg, 2010-03-16 23:45:25]

LGTM

On 17 March 2010 07:58,  <rsc@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: dpx, golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> version.bash: cope with ancient Mercurial
>
> Please review this at http://codereview.appspot.com/593043/show
>
> Affected files:
>  M src/version.bash
>
>
> Index: src/version.bash
> ===================================================================
> --- a/src/version.bash
> +++ b/src/version.bash
> @@ -10,10 +10,16 @@
>  fi
>
>  # Get numerical revision
> -VERSION="`hg identify -n`"
> +VERSION=$(hg identify -n 2>/dev/null)
> +if [ $? = 0 ]; then
> +       TAG=$(hg identify -t | sed 's!/release!!')
> +else
> +       OLD=$(hg identify | sed 1q)
> +       VERSION=$(echo $OLD | awk '{print $1}')
> +       TAG=$(echo $OLD | awk '{print $2}' | sed 's!/release!!')
> +fi
>
>  # Append tag if not 'tip'
> -TAG=$(hg identify -t | sed 's!/release!!')
>  if [[ "$TAG" != "tip" ]]; then
>        VERSION="$VERSION $TAG"
>  fi
>
>
>

[rsc, 2010-03-17 01:45:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=a66cbea29075 ***

version.bash: cope with ancient Mercurial

R=adg
CC=dpx, golang-dev
http://codereview.appspot.com/593043