Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5787)

Issue 5924044: code review 5924044: cmd/dist: fix detection of go1 version (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by rsc
Modified:
12 years, 5 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

cmd/dist: fix detection of go1 version

Patch Set 1 #

Patch Set 2 : diff -r 5266a934c287 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5266a934c287 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 35dd49c126bc https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/dist/build.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 5 months ago (2012-03-27 03:52:12 UTC) #1
r
LGTM
12 years, 5 months ago (2012-03-27 03:53:26 UTC) #2
rsc
12 years, 5 months ago (2012-03-27 04:17:38 UTC) #3
*** Submitted as f3f85952dd18 ***

cmd/dist: fix detection of go1 version

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5924044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b