Issue 5921045: code review 5921045: cmd/godoc: use virtual filesystem to implement -templat...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5921045: code review 5921045: cmd/godoc: use virtual filesystem to implement -templat... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by adg

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, gri, rsc

Visibility:
Public.

Description

cmd/godoc: use virtual filesystem to implement -templates flag

Patch Set 1 #

Patch Set 2 : diff -r 5d0322034aa8 https://code.google.com/p/go #

Patch Set 3 : diff -r 01acf1dbe91f https://code.google.com/p/go #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	src/cmd/godoc/godoc.go	View		1 chunk	+0 lines, -8 lines	0 comments	Download
	M	src/cmd/godoc/main.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

13 years, 1 month ago (2012-03-27 06:06:52 UTC) #1

rsc

LGTM Okay but only because we don't care about breaking godoc command lines in the ...

13 years, 1 month ago (2012-03-27 17:57:47 UTC) #3

adg

13 years, 1 month ago (2012-03-27 22:14:09 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=f5fbf05c731c ***

cmd/godoc: use virtual filesystem to implement -templates flag

R=golang-dev, gri, rsc
CC=golang-dev
http://codereview.appspot.com/5921045

Expand All Messages | Collapse All Messages