Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(581)

Issue 5919048: code review 5919048: cmd/go: update for go1 tag format (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by rsc
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, r, r2
Visibility:
Public.

Description

cmd/go: update for go1 tag format

Patch Set 1 #

Patch Set 2 : diff -r 5266a934c287 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5266a934c287 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 5266a934c287 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 118a2ea28f7e https://code.google.com/p/go/ #

Patch Set 6 : diff -r f3f85952dd18 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -2 lines) Patch
M src/cmd/go/get.go View 1 2 3 4 4 chunks +61 lines, -1 line 0 comments Download
M src/cmd/go/tag_test.go View 1 3 chunks +24 lines, -0 lines 0 comments Download
M src/cmd/go/vcs.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 8 months ago (2012-03-27 03:52:02 UTC) #1
r
http://codereview.appspot.com/5919048/diff/4001/src/cmd/go/get.go File src/cmd/go/get.go (right): http://codereview.appspot.com/5919048/diff/4001/src/cmd/go/get.go#newcode327 src/cmd/go/get.go:327: // goTag matches go release tags such as go.1 ...
13 years, 8 months ago (2012-03-27 03:56:53 UTC) #2
rsc
PTAL Grepped for 'go\.' and found a comment in vcs.go that needed fixing too. Obviously ...
13 years, 8 months ago (2012-03-27 03:59:04 UTC) #3
r
http://codereview.appspot.com/5919048/diff/5003/src/cmd/go/get.go File src/cmd/go/get.go (right): http://codereview.appspot.com/5919048/diff/5003/src/cmd/go/get.go#newcode337 src/cmd/go/get.go:337: // Version "go.N[.N[.N]]" matches tags of the form "go.N[.N[.N]]". ...
13 years, 8 months ago (2012-03-27 04:04:49 UTC) #4
rsc
how about // Version "goX" (or "goX.Y" or "goX.Y.Z") matches tags of the same form. ...
13 years, 8 months ago (2012-03-27 04:08:59 UTC) #5
r2
LGTM code looks given given the regexp, it's just the comments that seemed incorrect
13 years, 8 months ago (2012-03-27 04:10:29 UTC) #6
rsc
After Go 1 we can throw away the release.* code.
13 years, 8 months ago (2012-03-27 04:11:04 UTC) #7
rsc
13 years, 8 months ago (2012-03-27 04:17:54 UTC) #8
*** Submitted as 515964d0c89b ***

cmd/go: update for go1 tag format

R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/5919048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b