Issue 5907065: code review 5907065: gobuilder: work with codereview plugin enabled in .hgrc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5907065: code review 5907065: gobuilder: work with codereview plugin enabled in .hgrc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by minux1

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

gobuilder: work with codereview plugin enabled in .hgrc Fixes issue 3312.

Patch Set 2 : diff -r a50b793f143b https://code.google.com/p/go/ #

Patch Set 3 : diff -r feb586ac4860 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 8434de733c20 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 19228927c70d https://code.google.com/p/go/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
	M	misc/dashboard/builder/Makefile	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	misc/dashboard/builder/main.go	View	1 2 3	7 chunks	+17 lines, -13 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 3 months ago (2012-03-30 06:10:39 UTC) #1

adg

http://codereview.appspot.com/5907065/diff/4001/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): http://codereview.appspot.com/5907065/diff/4001/misc/dashboard/builder/main.go#newcode223 misc/dashboard/builder/main.go:223: if err := run(nil, goroot, "hg", "--config", "extensions.codereview=!", "pull"); ...

13 years, 3 months ago (2012-04-01 22:32:34 UTC) #2

minux1

PTAL. Refactored the code. Also modified Makefile to match our .hgignore.

13 years, 3 months ago (2012-04-02 06:38:31 UTC) #3

minux1

13 years, 3 months ago (2012-04-02 10:46:36 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=4f9605dc4a10 ***

gobuilder: work with codereview plugin enabled in .hgrc
        Fixes issue 3312.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5907065

Expand All Messages | Collapse All Messages