Issue 5903048: [ASan] use macro to define if we intercept should signal/sigaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5903048: [ASan] use macro to define if we intercept should signal/sigaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by samsonov

Modified:
12 years, 1 month ago

Reviewers:
kcc1, Evgeniy Stepanov

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	asan_interceptors.cc	View		5 chunks	+14 lines, -9 lines	2 comments	Download
	M	asan_internal.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Evgeniy Stepanov

lgtm http://codereview.appspot.com/5903048/diff/1/asan_interceptors.cc File asan_interceptors.cc (right): http://codereview.appspot.com/5903048/diff/1/asan_interceptors.cc#newcode41 asan_interceptors.cc:41: #if !defined(ANDROID) && !defined(_WIN32) Nit: please invert this ...

12 years, 1 month ago (2012-03-26 08:25:40 UTC) #2

samsonov

12 years, 1 month ago (2012-03-26 09:09:15 UTC) #3

r153140

http://codereview.appspot.com/5903048/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5903048/diff/1/asan_interceptors.cc#newcode41
asan_interceptors.cc:41: #if !defined(ANDROID) && !defined(_WIN32)
On 2012/03/26 08:25:40, Evgeniy Stepanov wrote:
> Nit: please invert this condition.

Done.

Expand All Messages | Collapse All Messages