Issue 5900045: [google/4.6] For -gfission, remove address table entry when removing location list entry

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5900045: [google/4.6] For -gfission, remove address table entry when removing location list entry

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Cary

Modified:
12 years, 1 month ago

Reviewers:
saugustine

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_6/gcc/

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	dwarf2out.c	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Cary

2012-03-23 Cary Coutant <ccoutant@google.com> * dwarf2out.c (resolve_addr): Remove address table entry for symbol when removing ...

12 years, 1 month ago (2012-03-23 22:40:15 UTC) #1

saugustine

On Fri, Mar 23, 2012 at 3:40 PM, Cary Coutant <ccoutant@google.com> wrote: > 2012-03-23 Cary ...

12 years, 1 month ago (2012-03-23 22:44:23 UTC) #2

saugustine

12 years, 1 month ago (2012-03-23 22:45:53 UTC) #3

On Fri, Mar 23, 2012 at 3:40 PM, Cary Coutant <ccoutant@google.com> wrote:
>
> 2012-03-23   Cary Coutant  <ccoutant@google.com>
>
>        * dwarf2out.c (resolve_addr): Remove address table entry for symbol
>        when removing location list entry.
>
>
> Index: dwarf2out.c
> ===================================================================
> --- dwarf2out.c (revision 185594)
> +++ dwarf2out.c (working copy)
> @@ -23803,11 +23803,15 @@ resolve_addr (dw_die_ref die)
>                if (!resolve_addr_in_expr ((*curr)->expr))
>                  {
>                    dw_loc_list_ref next = (*curr)->dw_loc_next;
> +                   dw_loc_descr_ref l = (*curr)->expr;
> +
>                    if (next && (*curr)->ll_symbol)
>                      {
>                        gcc_assert (!next->ll_symbol);
>                        next->ll_symbol = (*curr)->ll_symbol;
>                      }
> +                   if (l->dw_loc_oprnd1.val_index != -1U)
> +                     remove_addr_table_entry
> (l->dw_loc_oprnd1.val_index);
>                    *curr = next;
>                  }
>                else
>
> --
> This patch is available for review at
> http://codereview.appspot.com/5900045

This patch is OK for Google 4.6.

Sterling

Expand All Messages | Collapse All Messages