Minor additions to JsonHttpRequest and JsonHttpClient

http://code.google.com/p/google-http-java-client/issues/detail?id=62: Warn if there is no application name.

http://code.google.com/p/google-http-java-client/issues/detail?id=76: executeAsInputStream in JsonHttpRequest and JsonHttpClient

Removing deprecated methods from JsonHttpClient

[yanivi, 2012-03-23 22:59:58]

LGTM

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java
(right):

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:218:
protected HttpRequest buildHttpRequest(
[optional] while you're here, why not just delete these deprecated methods?

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:304:
* Builds and executes a {@link HttpRequest} and then returns the content input
stream of
a --> an

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:387:
if (applicationName == null) {
[optional] do you want to call Strings.isNullOrEmpty() here?

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:388:
LOGGER.warning("Application name is not set");
any time you show an error, it's best if you show how to fix the error too, e.g.
something like "call setApplicationName".

[rmistry, 2012-03-26 12:27:53]

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java
(right):

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:218:
protected HttpRequest buildHttpRequest(
On 2012/03/23 22:59:58, yanivi wrote:
> [optional] while you're here, why not just delete these deprecated methods?

Done.

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:304:
* Builds and executes a {@link HttpRequest} and then returns the content input
stream of
On 2012/03/23 22:59:58, yanivi wrote:
> a --> an

Done.

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:387:
if (applicationName == null) {
On 2012/03/23 22:59:58, yanivi wrote:
> [optional] do you want to call Strings.isNullOrEmpty() here?

Done.

http://codereview.appspot.com/5892044/diff/4001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java:388:
LOGGER.warning("Application name is not set");
On 2012/03/23 22:59:58, yanivi wrote:
> any time you show an error, it's best if you show how to fix the error too,
e.g.
> something like "call setApplicationName".

Done.

[rmistry, 2012-03-26 12:31:54]

Submitting..